set/k7
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allocate passphrase on demand.

Browse Source 
Don't store passphrase as char* member variable.
This would crash the application when exporting private keys.
See https://dev.gnupg.org/T5151#139421
This commit is contained in:
SET
2020-11-25 21:29:27 +01:00
parent 127cb7d738
commit de7880ae36
2 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
LoopbackPassphraseProvider.cpp
View File

@@ -14,13 +14,13 @@
LoopbackPassphraseProvider::LoopbackPassphraseProvider()
: PassphraseProvider()
{
m_passphrase = strdup("");
m_passphrase = "";
}
LoopbackPassphraseProvider::LoopbackPassphraseProvider(const string& passphrase)
: PassphraseProvider()
{
m_passphrase = strdup(passphrase.c_str());
m_passphrase = passphrase;
}
LoopbackPassphraseProvider::~LoopbackPassphraseProvider()
@@ -42,7 +42,10 @@ char* LoopbackPassphraseProvider::getPassphrase(const char* useridHint,
cout << previousWasBad << endl; // Always 0, even with bad password
cout << canceled << endl; // Always 0
*/
return m_passphrase;
/*
* See https://dev.gnupg.org/T5151#139421
*/
return strdup(m_passphrase.c_str());
}
void LoopbackPassphraseProvider::SetPassphrase(const string& passphrase)
@@ -50,7 +53,7 @@ void LoopbackPassphraseProvider::SetPassphrase(const string& passphrase)
/*
* Memory leak here ?
*/
m_passphrase = strdup(passphrase.c_str());
m_passphrase = passphrase;
}
const string LoopbackPassphraseProvider::GetPassphrase()